Moving the creation of /etc/docker and /etc/docker/daemon.json#535
Open
tomn46037 wants to merge 1 commit intogeerlingguy:masterfrom
Open
Moving the creation of /etc/docker and /etc/docker/daemon.json#535tomn46037 wants to merge 1 commit intogeerlingguy:masterfrom
tomn46037 wants to merge 1 commit intogeerlingguy:masterfrom
Conversation
…ore the install. The default-address-pools option must be in place for the install or docker will create the network with the wrong IP network.
Author
|
Hi, kinda new to git/github and pull requests. :) I thought I was merging this into my master branch. But this was the eventual goal anyway. If this isn't the right way to do this, or you need any changes - I'm happy to update it. Thanks for all the work you put in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the creation of /etc/docker and /etc/docker/daemon.json to before the install. The default-address-pools option must be in place for the install or docker will create the network with the wrong IP network. This is because the networks are created during the installation of docker.